[Migration review - DO NOT MERGE] Supplier + proof modules #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
supplier
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| return nil | ||
| } | ||
| // TODO_IN_THIS_COMMIT: uncomment |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_COMMIT: uncomment
|
|
||
| servicehelpers "github.com/pokt-network/poktroll/x/shared/helpers" | ||
| sharedtypes "github.com/pokt-network/poktroll/x/shared/types" | ||
| ) | ||
|
|
||
| const TypeMsgStakeSupplier = "stake_supplier" | ||
|
|
||
| var _ sdk.Msg = (*MsgStakeSupplier)(nil) | ||
| var _ sdk.Msg = &MsgStakeSupplier{} |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
var _ sdk.Msg = &MsgStakeSupplier{}
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| ) | ||
|
|
||
| const TypeMsgUnstakeSupplier = "unstake_supplier" | ||
|
|
||
| var _ sdk.Msg = (*MsgUnstakeSupplier)(nil) | ||
| var _ sdk.Msg = &MsgUnstakeSupplier{} |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
var _ sdk.Msg = &MsgUnstakeSupplier{}
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| ) | ||
|
|
||
| var _ sdk.Msg = &MsgUpdateParams{} |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
var _ sdk.Msg = &MsgUpdateParams{}
bryanchriswhite
changed the title
…take:coin services
bryanchriswhite
force-pushed
the
migration/review/supplier-module
branch
from
cc6b8f9 to
9faa010
Compare
11 tasks
bryanchriswhite
changed the title
11 tasks
|
Add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
Review branch for the supplier module migration to rollkit/cosmos-sdk v0.50.x (see: migration notion doc).
Once this branch is approved:
git diff origin/migration/supplier-module..origin/migration/review/supplier-moduleNOTE:
*.pulsar.gocode.proto/supplier/...,x/supplier/...) and dependencies.Issue
Type of change
Select one or more:
Testing
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR. This is VERY expensive, only do it after all the reviews are complete.Sanity Checklist